Page MenuHomePhabricator

keystore GetKeys(): return result instead of writing to reference

Authored by Fabien on Dec 17 2018, 13:28.



Add a missing lock to crypter GetKeys() (see core issue #10905)

Backport of core PR10916

Test Plan
./test/functional/ wallet_dump

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Dec 17 2018, 13:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 17 2018, 13:28
Herald added a subscriber: schancel. · View Herald Transcript
Fabien edited the test plan for this revision. (Show Details)Dec 17 2018, 13:29
deadalnix accepted this revision.Dec 20 2018, 10:22
deadalnix added inline comments.
33 ↗(On Diff #6354)

Who came up with that API ? Seriously ?

This revision is now accepted and ready to land.Dec 20 2018, 10:22
This revision was automatically updated to reflect the committed changes.