keystore GetKeys(): return result instead of writing to reference
ClosedPublic
Actions

Authored by Fabien on Dec 17 2018, 13:28.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe4789034bfa9: keystore GetKeys(): return result instead of writing to reference
rABCe4789034bfa9: keystore GetKeys(): return result instead of writing to reference

Summary

Add a missing lock to crypter GetKeys() (see core issue #10905)

Backport of core PR10916

Test Plan

./test/functional/test_runner.py wallet_dump

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10916

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4324
Build 6713: Bitcoin ABC Buildbot (legacy)
Build 6712: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 17 2018, 13:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 17 2018, 13:28

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Fabien edited the test plan for this revision. (Show Details)Dec 17 2018, 13:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4324: Diff 6354.Dec 17 2018, 13:38

deadalnix accepted this revision.Dec 20 2018, 10:22

deadalnix added inline comments.

src/keystore.h
33	Who came up with that API ? Seriously ?

This revision is now accepted and ready to land.Dec 20 2018, 10:22

Closed by commit rABCe4789034bfa9: keystore GetKeys(): return result instead of writing to reference (authored by Marko Bencun <marko.bencun@monetas.net>, committed by Fabien). · Explain WhyDec 21 2018, 11:58

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

keystore.h

17 lines

wallet/

crypter.h

15 lines

wallet.cpp

5 lines

Diff 6354

View Options

src/keystore.h

View Options

src/wallet/crypter.h

View Options

keystore GetKeys(): return result instead of writing to referenceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6354

src/keystore.h

src/wallet/crypter.h

src/wallet/wallet.cpp

keystore GetKeys(): return result instead of writing to reference
ClosedPublic
Actions

Revision Contents
Changeset List