More user-friendly error message when partially signing
ClosedPublic
Actions

Authored by Fabien on Dec 21 2018, 16:00.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING1789c2af0bd5: More user-friendly error message when partially signing
rABC1789c2af0bd5: More user-friendly error message when partially signing

Summary

Backport of core PR11288

Test Plan

./test/functional/test_runner.py signrawtransaction

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 21 2018, 16:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2018, 16:00

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien mentioned this in D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.Dec 21 2018, 16:02

Fabien added a child revision: D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.Dec 21 2018, 16:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4343: Diff 6393.Dec 21 2018, 16:09

deadalnix accepted this revision.Dec 21 2018, 19:04

This revision is now accepted and ready to land.Dec 21 2018, 19:04

Closed by commit rABC1789c2af0bd5: More user-friendly error message when partially signing (authored by MeshCollider <dobsonsa68@gmail.com>, committed by Fabien). · Explain WhyDec 21 2018, 19:44

This revision was automatically updated to reflect the committed changes.

Fabien removed a child revision: D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.Feb 11 2019, 12:23

Fabien added a child revision: D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.Feb 12 2019, 09:44

Fabien removed a child revision: D2007: [Part 1 of 3] Split signrawtransaction into wallet and non-wallet.Feb 12 2019, 10:02

Revision Contents
Changeset List

Path

Size

src/

rpc/

rawtransaction.cpp

10 lines

Diff 6399

View Options

src/rpc/rawtransaction.cpp

More user-friendly error message when partially signingClosedPublicActions