Page MenuHomePhabricator

Update connect_nodes API so it does take the node object directly
ClosedPublic

Authored by deadalnix on Dec 21 2018, 17:08.

Details

Summary

This ensures that we can update it later on to not depend on global state.

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Dec 21 2018, 17:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2018, 17:08
Herald added a subscriber: schancel. · View Herald Transcript
jasonbcox accepted this revision.Dec 21 2018, 21:33
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/p2p-acceptblock.py
165 ↗(On Diff #6395)

Nit: shouldn't need a space on this line or the next addition line

This revision is now accepted and ready to land.Dec 21 2018, 21:33
This revision was automatically updated to reflect the committed changes.