Page MenuHomePhabricator
Differential D2215

Update connect_nodes API so it does take the node object directly
ClosedPublic
Actions

Authored by deadalnix on Dec 21 2018, 17:08.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGa9bed00cfd4f: Update connect_nodes API so it does take the node object directly
rABCa9bed00cfd4f: Update connect_nodes API so it does take the node object directly
Summary

This ensures that we can update it later on to not depend on global state.

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
connect_nodes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4345
Build 6755: Bitcoin ABC Buildbot (legacy)
Build 6754: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 21 2018, 17:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2018, 17:08
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 21 2018, 17:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 21 2018, 17:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4345: Diff 6395.Dec 21 2018, 17:18
jasonbcox accepted this revision.Dec 21 2018, 21:33
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/p2p-acceptblock.py
165

Nit: shouldn't need a space on this line or the next addition line

This revision is now accepted and ready to land.Dec 21 2018, 21:33
Closed by commit rABCa9bed00cfd4f: Update connect_nodes API so it does take the node object directly (authored by deadalnix). · Explain WhyDec 22 2018, 16:36
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
2 lines
2 lines
4 lines
2 lines
6 lines
2 lines
6 lines
20 lines
test_framework/
12 lines
2 lines
2 lines
16 lines

Diff 6395

View Options

test/functional/abandonconflict.py

Loading...
View Options

test/functional/bip68-sequence.py

Loading...
View Options

test/functional/example_test.py

Loading...
View Options

test/functional/import-rescan.py

Loading...
View Options

test/functional/merkle_blocks.py

Loading...
View Options

test/functional/minchainwork.py

Loading...
View Options

test/functional/p2p-acceptblock.py

Loading...
View Options

test/functional/pruning.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...
View Options

test/functional/txn_clone.py

Loading...
View Options

test/functional/txn_doublespend.py

Loading...
View Options

test/functional/walletbackup.py

Loading...