Page MenuHomePhabricator

Temporarly skip running rpcbind_test on WSL
ClosedPublic

Authored by Fabien on Dec 29 2018, 18:10.

Details

Summary

Skip the test while netstat is not supported in WSL.
Related to T400.

Test Plan

On WSL and native linux run:

./test/functional/test_runner.py rpcbind_test

Check that test_runner outputs the test as skipped on WSL
Check that test_runner outputs a "Passed" status for the test on native linux

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Dec 29 2018, 18:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 29 2018, 18:10
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Dec 30 2018, 12:08

I do not think the test plan appropriately test the change.

This revision now requires changes to proceed.Dec 30 2018, 12:08
Fabien edited the test plan for this revision. (Show Details)Dec 30 2018, 13:02
Fabien edited the test plan for this revision. (Show Details)
Fabien requested review of this revision.Dec 30 2018, 13:06
Fabien edited the test plan for this revision. (Show Details)

Updated test plan

jasonbcox requested changes to this revision.Dec 30 2018, 18:10
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/rpcbind_test.py
62 ↗(On Diff #6451)

Please update the comment to point to https://reviews.bitcoinabc.org/T400 and note that this message can be removed once netstat support is provided by Microsoft.

This revision now requires changes to proceed.Dec 30 2018, 18:10
Fabien updated this revision to Diff 6468.Dec 31 2018, 13:15
Fabien edited the test plan for this revision. (Show Details)

Complete the comment with details according to feedback

deadalnix added inline comments.Dec 31 2018, 14:20
test/functional/rpcbind_test.py
65 ↗(On Diff #6468)

It's not really about removing the message, but reenabling test.

deadalnix accepted this revision.Dec 31 2018, 14:20
Fabien updated this revision to Diff 6473.Dec 31 2018, 14:48

Improve the comment message according to feedback

jasonbcox added inline comments.Jan 1 2019, 00:07
test/functional/rpcbind_test.py
65 ↗(On Diff #6468)

ya, that's a more accurate way of phrasing it.

jasonbcox accepted this revision.Jan 1 2019, 00:08
jasonbcox added inline comments.
test/functional/rpcbind_test.py
65 ↗(On Diff #6468)

As a nit, you can reword this message. Green-ing this diff since the rest looks good.

This revision is now accepted and ready to land.Jan 1 2019, 00:08
This revision was automatically updated to reflect the committed changes.