Page MenuHomePhabricator

Remove redundant testutil files
ClosedPublic

Authored by Fabien on Sun, Dec 30, 17:01.

Details

Summary

The only function in testutil.cpp, GetTempPath() simply called
fs::temp_directory_path() directly. This just tidies things up by
removing that redundant function and the file containing it.

Backport of PR11234

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Sun, Dec 30, 17:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Dec 30, 17:01
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Sun, Dec 30, 19:02

You need to update the cmake build as well.

This revision now requires changes to proceed.Sun, Dec 30, 19:02
Fabien updated this revision to Diff 6472.Mon, Dec 31, 13:37

Fix the CMake build

Fabien edited the test plan for this revision. (Show Details)Mon, Dec 31, 13:38
deadalnix accepted this revision.Mon, Dec 31, 14:21
This revision is now accepted and ready to land.Mon, Dec 31, 14:21
Closed by commit rABCe471a2ded163: Remove redundant testutil files (authored by MeshCollider <dobsonsa68@gmail.com>, committed by Fabien). · Explain WhyMon, Dec 31, 14:51
This revision was automatically updated to reflect the committed changes.