Page MenuHomePhabricator

Remove redundant testutil files
ClosedPublic

Authored by Fabien on Dec 30 2018, 17:01.

Details

Summary

The only function in testutil.cpp, GetTempPath() simply called
fs::temp_directory_path() directly. This just tidies things up by
removing that redundant function and the file containing it.

Backport of PR11234

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Dec 30 2018, 17:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 30 2018, 17:01
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Dec 30 2018, 19:02

You need to update the cmake build as well.

This revision now requires changes to proceed.Dec 30 2018, 19:02
Fabien updated this revision to Diff 6472.Dec 31 2018, 13:37

Fix the CMake build

Fabien edited the test plan for this revision. (Show Details)Dec 31 2018, 13:38
deadalnix accepted this revision.Dec 31 2018, 14:21
This revision is now accepted and ready to land.Dec 31 2018, 14:21
This revision was automatically updated to reflect the committed changes.