Page MenuHomePhabricator
Differential D2244

Remove redundant testutil files
ClosedPublic
Actions

Authored by Fabien on Dec 30 2018, 17:01.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGe471a2ded163: Remove redundant testutil files
rABCe471a2ded163: Remove redundant testutil files
Summary

The only function in testutil.cpp, GetTempPath() simply called
fs::temp_directory_path() directly. This just tidies things up by
removing that redundant function and the file containing it.

Backport of PR11234

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11234
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4390
Build 6845: Bitcoin ABC Buildbot (legacy)
Build 6844: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 30 2018, 17:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 30 2018, 17:01
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 30 2018, 17:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 30 2018, 17:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4388: Diff 6467.Dec 30 2018, 17:11
deadalnix requested changes to this revision.Dec 30 2018, 19:02

You need to update the cmake build as well.

This revision now requires changes to proceed.Dec 30 2018, 19:02
Fabien updated this revision to Diff 6472.Dec 31 2018, 13:37

Fix the CMake build

Fabien edited the test plan for this revision. (Show Details)Dec 31 2018, 13:38
deadalnix accepted this revision.Dec 31 2018, 14:21
This revision is now accepted and ready to land.Dec 31 2018, 14:21
teamcity added a comment.Dec 31 2018, 14:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 31 2018, 14:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4390: Diff 6472.Dec 31 2018, 14:35
Closed by commit rABCe471a2ded163: Remove redundant testutil files (authored by MeshCollider <dobsonsa68@gmail.com>, committed by Fabien). · Explain WhyDec 31 2018, 14:51
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6472

View Options

src/Makefile.qttest.include

Loading...
View Options

src/Makefile.test.include

Loading...
View Options

src/qt/test/CMakeLists.txt

Loading...
View Options

src/qt/test/rpcnestedtests.cpp

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...
View Options

src/test/testutil.h

Loading...
View Options

src/test/testutil.cpp

Loading...