Page MenuHomePhabricator

Avoid opening copied wallet databases simultaneously
ClosedPublic

Authored by Fabien on Jan 9 2019, 21:00.

Details

Summary

Make sure wallet databases have unique fileids. If they don't, throw an
error.
BDB caches do not work properly when more than one open database has the
same fileid, because values written to one database may show up in reads
to other databases.

Bitcoin will never create different databases with the same fileid, but
users can create them by manually copying database files.

Backport of core PR11476

Depends on D2278

Test Plan
make check
./test/functional/test_runner.py multiwallet

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11476
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4458
Build 6980: Bitcoin ABC Buildbot (legacy)
Build 6979: arc lint + arc unit