Page MenuHomePhabricator

qa: Remove unused NodeConn members
ClosedPublic

Authored by Fabien on Jan 19 2019, 17:51.

Details

Summary

Backport of core PR11677

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11677
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4584
Build 7231: Bitcoin ABC Buildbot (legacy)
Build 7230: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Jan 20 2019, 00:56

You should rebase this on top of something clean. The CI failed for something that looks unrelated to that patch.

The patch itself looks good. The fact that the changes were limited to abc tests illustrates that we probably aren't doing what's best in these and other tests use an alternative to achieve the same end goal. It would be interesting to look into what that alternative is.

This revision now requires changes to proceed.Jan 20 2019, 00:56

The CI seems to have some trouble, it failed to fetch the diff.
It's likely that the abc-* tests here can be improved, I put it on my todo list but I prefer to do it in a later diff.

This revision is now accepted and ready to land.Jan 20 2019, 14:53
This revision was automatically updated to reflect the committed changes.