Page MenuHomePhabricator
Differential D2350

[RCU] Add new features to RCUPtr
ClosedPublic
Actions

Authored by deadalnix on Jan 20 2019, 17:54.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGe2c7376a162f: [RCU] Add new features to RCUPtr
rABCe2c7376a162f: [RCU] Add new features to RCUPtr
Summary
  • Make constructor private and add factory methods to clear up ownership.
  • Add a release method for the RCUPtr to give up ownership.
  • Add get method to get the underlying pointer.
  • Add operator* overloads.
  • Add an explicit convertion to bool that checks for null
Test Plan

Added tests cases that uses all these methods.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
betterrcuptr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4592
Build 7247: Bitcoin ABC Buildbot (legacy)
Build 7246: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 20 2019, 17:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2019, 17:54
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix added a parent revision: D2340: [RCU] Implement RCUPtr, a smart pointer that free asynchronousely when other threads did synchronize..Jan 20 2019, 17:55
teamcity added a subscriber: teamcity.Jan 20 2019, 17:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 20 2019, 18:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4592: Diff 6760!Jan 20 2019, 18:06
teamcity added a comment.Jan 20 2019, 20:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 20 2019, 21:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix added a child revision: D2352: [RCU] Make RCUPtr compatible with const payloads..Jan 20 2019, 22:16
deadalnix added a child revision: D2351: [RCU] Implement equality check for RCUPtr.Jan 21 2019, 16:56
jasonbcox requested changes to this revision.Jan 24 2019, 20:53
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/rcu.h
78

nit: stylistically, I think private: should be added at the top of this class and the others in this file.

95

acquire(nullptr) needs test case

112

copy(nullptr) needs test case

This revision now requires changes to proceed.Jan 24 2019, 20:53
deadalnix requested review of this revision.Jan 25 2019, 21:24
deadalnix added inline comments.
src/test/rcu_tests.cpp
206

What is that ?

jasonbcox accepted this revision.Jan 25 2019, 22:35

Dunno how I missed it.

This revision is now accepted and ready to land.Jan 25 2019, 22:35
deadalnix updated this revision to Diff 6992.Jan 29 2019, 19:06

rebase

teamcity added a comment.Jan 29 2019, 19:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 29 2019, 19:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4743: Diff 6992!Jan 29 2019, 19:12
deadalnix updated this revision to Diff 6998.Jan 29 2019, 20:46

Use the NULLPTR macro to work around a bug in boost.

teamcity added a comment.Jan 29 2019, 20:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 29 2019, 21:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4749: Diff 6998!Jan 29 2019, 21:01
Closed by commit rABCe2c7376a162f: [RCU] Add new features to RCUPtr (authored by deadalnix). · Explain WhyJan 29 2019, 23:24
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rSTAGINGe2c7376a162f: [RCU] Add new features to RCUPtr.Sep 18 2019, 22:08

Revision Contents
Changeset List

PathSize
src/
47 lines
test/
42 lines

Diff 6760

View Options

src/rcu.h

Loading...
View Options

src/test/rcu_tests.cpp

Loading...