Page MenuHomePhabricator
Differential D2351

[RCU] Implement equality check for RCUPtr
ClosedPublic
Actions

Authored by deadalnix on Jan 20 2019, 19:17.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING806dd8d53721: [RCU] Implement equality check for RCUPtr
rABC806dd8d53721: [RCU] Implement equality check for RCUPtr
Summary

It is more convenient to manipulate them that way.

Test Plan

Added tests cases.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
equalrcuptr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4751
Build 7565: Bitcoin ABC Buildbot (legacy)
Build 7564: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 20 2019, 19:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 20 2019, 19:17
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 20 2019, 19:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 20 2019, 19:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4593: Diff 6761!Jan 20 2019, 19:28
teamcity added a comment.Jan 20 2019, 20:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 20 2019, 20:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix added a child revision: D2371: [Radix] Use RCUPtr to keep track of items in the tree.Jan 21 2019, 16:56
deadalnix added a parent revision: D2350: [RCU] Add new features to RCUPtr.Jan 21 2019, 16:56
jasonbcox accepted this revision.Jan 24 2019, 20:39
This revision is now accepted and ready to land.Jan 24 2019, 20:39
deadalnix updated this revision to Diff 7000.Jan 29 2019, 20:57

rebase and use the NULLPTR marco to work around a bug in Boost.

teamcity added a comment.Jan 29 2019, 20:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 7001.Jan 29 2019, 21:03

Actually use NULLPTR consistently

teamcity added a comment.Jan 29 2019, 21:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B4751: Diff 7000!Jan 29 2019, 21:03
teamcity added a comment.Jan 29 2019, 21:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster completed remote builds in B4752: Diff 7001.Jan 29 2019, 21:16
teamcity added a comment.Jan 29 2019, 21:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC806dd8d53721: [RCU] Implement equality check for RCUPtr (authored by deadalnix). · Explain WhyJan 29 2019, 23:24
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rSTAGING806dd8d53721: [RCU] Implement equality check for RCUPtr.Sep 18 2019, 22:08

Revision Contents
Changeset List

PathSize
src/
27 lines
test/
36 lines

Diff 7000

View Options

src/rcu.h

Loading...
View Options

src/test/rcu_tests.cpp

Loading...