[RCU] Use assert in tests instead of BOOST_CHECK when they aren't in the main thread.
ClosedPublic
Actions

Authored by deadalnix on Jan 21 2019, 15:54.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING5158d7f79c63: [RCU] Use assert in tests instead of BOOST_CHECK when they aren't in the main…
rABC5158d7f79c63: [RCU] Use assert in tests instead of BOOST_CHECK when they aren't in the main…

Summary

Boost test is unable to manage these properly, so asserts are preferable.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rcuinvestigation

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4610
Build 7283: Bitcoin ABC Buildbot (legacy)
Build 7282: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jan 21 2019, 15:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2019, 15:54

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4610: Diff 6780.Jan 21 2019, 16:04

Fabien accepted this revision.Jan 21 2019, 17:03

This revision is now accepted and ready to land.Jan 21 2019, 17:03

Closed by commit rABC5158d7f79c63: [RCU] Use assert in tests instead of BOOST_CHECK when they aren't in the main… (authored by deadalnix). · Explain WhyJan 21 2019, 17:21

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rSTAGING5158d7f79c63: [RCU] Use assert in tests instead of BOOST_CHECK when they aren't in the main….Sep 18 2019, 21:59

Revision Contents
Changeset List

Path

Size

src/

test/

rcu_tests.cpp

14 lines

Diff 6780

View Options

[RCU] Use assert in tests instead of BOOST_CHECK when they aren't in the main thread.ClosedPublicActions