Differential D2408

CKeystore/CCrypter: move relevant implementation out of the header
ClosedPublic
Actions

Authored by Fabien on Jan 24 2019, 14:36.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGefef1906174c: CKeystore/CCrypter: move relevant implementation out of the header
rABCefef1906174c: CKeystore/CCrypter: move relevant implementation out of the header

Summary

This is a refactoring backport, no functional change is made here.

Backport of core PR11272

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11272_part1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4688
Build 7439: Bitcoin ABC Buildbot (legacy)
Build 7438: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 24 2019, 14:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2019, 14:36

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2410: Fix code style in keystore.cpp/crypter.cpp.Jan 24 2019, 14:43

deadalnix requested changes to this revision.Jan 24 2019, 14:43

deadalnix added inline comments.

src/keystore.cpp
53	Remove unnecessary scope.
src/wallet/crypter.cpp
162	Remove useless scope

This revision now requires changes to proceed.Jan 24 2019, 14:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4688: Diff 6902.Jan 24 2019, 14:51

Fabien requested review of this revision.Jan 24 2019, 14:54

Fabien added inline comments.

src/keystore.cpp
53	There are a lot of nits like this, which are covered by D2410. In the original PR they were in separated diffs, and I kept them separated here to make it easier to review as it does not break anything. I can still squash if you want.

Just saw your comment in the other diff, will squash

Squash with D2010

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien edited the summary of this revision. (Show Details)Jan 24 2019, 14:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4691: Diff 6905.Jan 24 2019, 15:10

deadalnix accepted this revision.Jan 24 2019, 15:17

This revision is now accepted and ready to land.Jan 24 2019, 15:17

Closed by commit rABCefef1906174c: CKeystore/CCrypter: move relevant implementation out of the header (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by Fabien). · Explain WhyJan 24 2019, 15:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGINGefef1906174c: CKeystore/CCrypter: move relevant implementation out of the header.Sep 18 2019, 22:04

Revision Contents
Changeset List

Path

Size

src/

30 lines

26 lines

wallet/

33 lines

32 lines

Diff 6902

src/keystore.h

Loading...

src/keystore.cpp

Loading...

src/wallet/crypter.h

Loading...

src/wallet/crypter.cpp

Loading...