Page MenuHomePhabricator

CKeystore/CCrypter: move relevant implementation out of the header
ClosedPublic

Authored by Fabien on Jan 24 2019, 14:36.

Details

Summary

This is a refactoring backport, no functional change is made here.

Backport of core PR11272

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11272_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4688
Build 7439: Bitcoin ABC Buildbot (legacy)
Build 7438: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Jan 24 2019, 14:43
deadalnix added inline comments.
src/keystore.cpp
53

Remove unnecessary scope.

src/wallet/crypter.cpp
162

Remove useless scope

This revision now requires changes to proceed.Jan 24 2019, 14:43
Fabien requested review of this revision.Jan 24 2019, 14:54
Fabien added inline comments.
src/keystore.cpp
53

There are a lot of nits like this, which are covered by D2410.
In the original PR they were in separated diffs, and I kept them separated here to make it easier to review as it does not break anything.
I can still squash if you want.

Fabien planned changes to this revision.Jan 24 2019, 14:55

Just saw your comment in the other diff, will squash

This revision is now accepted and ready to land.Jan 24 2019, 15:17
This revision was automatically updated to reflect the committed changes.