Page MenuHomePhabricator
Differential D2414

tests: Fix test_runner return value in case of skipped test
ClosedPublic
Actions

Authored by jasonbcox on Jan 25 2019, 00:38.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING1da1ddd10d3a: tests: Fix test_runner return value in case of skipped test
rABC1da1ddd10d3a: tests: Fix test_runner return value in case of skipped test
Summary

Currently test_runner reports an error if a test case is skipped.
This is not how it should be, only failed tests should cause it to fail.

Backport of Core PR10187
https://github.com/bitcoin/bitcoin/pull/10187/files
This fixes the phantom failures that reported no actual error in CI.

Test Plan

Tested this patch on a CI machine

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
test/
functional/
8 lines

Diff 6935

View Options

test/functional/test_runner.py

Loading...