Remove explicit server from the check-keys.sh script
ClosedPublic
Actions

Authored by Fabien on Jan 28 2019, 07:16.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING029cba792584: Remove explicit server from the check-keys.sh script
rABC029cba792584: Remove explicit server from the check-keys.sh script

Summary

There is no reason to enforce using this server rather than another.
Relying on the user configuration seems to be a better solution, as the
key servers tend to be all synchronized.

Test Plan

./check-keys.sh

Check the keys are retrieved or already known

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 28 2019, 07:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2019, 07:16

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien mentioned this in D2421: Add Fabien to the keys for gitian signing.Jan 28 2019, 07:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4717: Diff 6953.Jan 28 2019, 07:33

I'm against this because the default configuration for Ubuntu tends to pick a server like pgp.mit.edu which has very poor uptime. You are free to use whatever keyserver you see fit, but it makes sense to pick one that works at least 99% of the time.

This revision now requires changes to proceed.Jan 28 2019, 18:13

We talked more offline and it's clear that using this keyserver by default doesn't not work well on all configurations. It just happens to work well on my machines.

This revision is now accepted and ready to land.Jan 28 2019, 19:27

Closed by commit rABC029cba792584: Remove explicit server from the check-keys.sh script (authored by Fabien). · Explain WhyFeb 21 2019, 16:55

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in rABCb75173193d0b: Add Fabien to the keys for gitian signing.Feb 28 2019, 19:00

Fabien added a commit: rSTAGING029cba792584: Remove explicit server from the check-keys.sh script.Sep 18 2019, 22:28

Fabien mentioned this in rSTAGINGb75173193d0b: Add Fabien to the keys for gitian signing.Sep 18 2019, 22:35