Display the network limited flag in peer details
ClosedPublic
Actions

Authored by Fabien on Jan 30 2019, 10:29.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING826b021f51c7: Display the network limited flag in peer details
rABC826b021f51c7: Display the network limited flag in peer details

Summary

Display "LIMITED" for network limited nodes.
Note that the avalanche flag is not displayed, because it is in the
experimental range.

Test Plan

./src/qt/bitcoin-qt -prune=550 &
mkdir /tmp/datadir
./src/qt/bitcoin-qt -datadir=/tmp/datadir -connect=127.0.0.1

In the second instance:
Go to "Help=>Debug window"
Select the tab "Peers"
Click the 127.0.0.1 peer in the upper table
Check in the details that the LIMITED flag is displayed

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4763
Build 7589: Bitcoin ABC Buildbot (legacy)
Build 7588: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 30 2019, 10:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 30 2019, 10:29

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4763: Diff 7016.Jan 30 2019, 10:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Jan 30 2019, 13:34

deadalnix added inline comments.

src/qt/guiutil.cpp
891	This would benefit from being a constant.

This revision is now accepted and ready to land.Jan 30 2019, 13:34

Closed by commit rABC826b021f51c7: Display the network limited flag in peer details (authored by Fabien). · Explain WhyJan 30 2019, 15:05

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in D2452: Make the number service of service flag bits to display a constant.Jan 30 2019, 15:17

Fabien mentioned this in rABCa36c8cbcde44: Make the number service of service flag bits to display a constant.Feb 9 2019, 08:13

Fabien added a commit: rSTAGING826b021f51c7: Display the network limited flag in peer details.Sep 18 2019, 22:09

Fabien mentioned this in rSTAGINGa36c8cbcde44: Make the number service of service flag bits to display a constant.Sep 18 2019, 22:20

Revision Contents
Changeset List

Path

Size

src/

qt/

guiutil.cpp

7 lines

Diff 7016

View Options

Display the network limited flag in peer detailsClosedPublicActions