Differential D246

Make sure we generate a block bigger than 1MB by stuffing the coinbase when required
ClosedPublic
Actions

Authored by deadalnix on Jun 21 2017, 20:56.

Tags

None

Subscribers

None

Details

Reviewers

freetrader
hanchon

Group Reviewers

Restricted Project

Commits

rSTAGING9c1ddd0ae242: Make sure we generate a block bigger than 1MB by stuffing the coinbase when…
rABC9c1ddd0ae242: Make sure we generate a block bigger than 1MB by stuffing the coinbase when…

Test Plan

It builds, not sure it works.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 21 2017, 20:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 21 2017, 20:56

Harbormaster completed remote builds in B382: Diff 612.Jun 21 2017, 20:56

freetrader added inline comments.Jun 22 2017, 08:28

src/miner.cpp
209 ↗	(On Diff #612)	My feeling is it would be better to limit this block stuffing to testnets. But there is an argument to be made for keeping the code path the same and trying to eliminate as much uncertainty as possible from the mainnet fork.

Cleanup the whole thing.
Tested it work by forking testnet at 1498127000 .

Harbormaster completed remote builds in B386: Diff 619.Jun 22 2017, 12:21

I'm ok with these changes and have convinced myself (by a little math) that the block stuffing works as advertised.

src/miner.cpp
216 ↗	(On Diff #619)	spelling of comitmentSize and missingComitment in this section commitment

freetrader accepted this revision.Jun 22 2017, 13:10

This revision is now accepted and ready to land.Jun 22 2017, 13:10

Fix typos

Closed by commit rABC9c1ddd0ae242: Make sure we generate a block bigger than 1MB by stuffing the coinbase when… (authored by hanchon, committed by deadalnix). · Explain WhyJun 22 2017, 13:20

This revision was automatically updated to reflect the committed changes.

deadalnix mentioned this in T50: Ensure we mine a big block when it must be big.Jun 22 2017, 21:02

Revision Contents
Changeset List

Path

Size

src/

3 lines

46 lines

rpc/

1 line

2 lines

4 lines

Diff 622

src/httprpc.cpp

Loading...

src/miner.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...