Page MenuHomePhabricator

Remove duplicated whitelist=127.0.0.1 argument from comptool tests
AbandonedPublic

Authored by Fabien on Feb 4 2019, 10:05.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

Due to D2459, when extra_args are specified in a test, they extend the
argument list instead of replacing it. As -whitelist=127.0.0.1 is the
default for ComparisonFramework test nodes, specifying it in the test
extra_args is no longer needed.

Depends on D2459

Test Plan
./test/functional/test_runner.py abc-p2p-compactblocks

abc-p2p-fullblocktest abc-replay-protection abc-transaction-ordering
feature_block feature_csv_activation p2p_invalid_block

Diff Detail

Repository
rABC Bitcoin ABC
Branch
comptool_remove_whitelist
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4857
Build 7777: Bitcoin ABC Teamcity Staging
Build 7776: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 4 2019, 10:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2019, 10:05
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Feb 4 2019, 12:54

This illustrates one more problem for D2459 . What if one doesn't want 127.0.0.1, for instance to test for bans?

This revision now requires changes to proceed.Feb 4 2019, 12:54
Fabien abandoned this revision.Feb 5 2019, 08:41