Page MenuHomePhabricator
Differential D2498

[CMAKE] Fix cmake check-functional dependencies
ClosedPublic
Actions

Authored by Fabien on Feb 4 2019, 15:54.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING1f651f46bcb8: [CMAKE] Fix cmake check-functional dependencies
rABC1f651f46bcb8: [CMAKE] Fix cmake check-functional dependencies
Summary

test_runner.py does not need bitcoin-test-util.py to run, but requires bitcoin-cli for some tests.

Test Plan

Run:

cmake -DBUILD_BITCOIN_CLI=OFF -GNinja .. && ninja check-functional

It should return:
ninja: error: '../src/bitcoin-cli', needed by 'test/CMakeFiles/check-functional', missing and no known rule to make it

Should return no error (clear the cache first):

cmake -GNinja .. && ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_remove_useless_dep
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4867
Build 7797: Bitcoin ABC Buildbot (legacy)
Build 7796: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 4 2019, 15:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2019, 15:54
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 4 2019, 15:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien planned changes to this revision.Feb 4 2019, 16:07
teamcity added a comment.Feb 4 2019, 16:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4867: Diff 7162.Feb 4 2019, 16:08
Fabien retitled this revision from [CMAKE] Remove useless dependency to bitcoin-test-util for test_runner to [CMAKE] Fix cmake check-functional dependencies.Feb 4 2019, 16:15
Fabien edited the summary of this revision. (Show Details)
Fabien edited the test plan for this revision. (Show Details)
Fabien updated this revision to Diff 7166.Feb 4 2019, 16:16

Also add bitcoin-cli dependency

teamcity added a comment.Feb 4 2019, 16:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4869: Diff 7166.Feb 4 2019, 16:30
teamcity added a comment.Feb 4 2019, 16:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Feb 4 2019, 16:36
This revision is now accepted and ready to land.Feb 4 2019, 16:36
Fabien mentioned this in D2494: [CMAKE] Run test/util/bitcoin-util-test.py with ninja check.Feb 4 2019, 17:36
Closed by commit rABC1f651f46bcb8: [CMAKE] Fix cmake check-functional dependencies (authored by Fabien). · Explain WhyFeb 5 2019, 08:15
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING1f651f46bcb8: [CMAKE] Fix cmake check-functional dependencies.Sep 18 2019, 22:16

Revision Contents
Changeset List

PathSize
test/
1 line

Diff 7162

View Options

test/CMakeLists.txt

Loading...