Page MenuHomePhabricator

Fix script error description
ClosedPublic

Authored by florian on Wed, Feb 6, 04:11.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCb1eb229c4c3f: Fix script error description
Summary

As per title

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

florian created this revision.Wed, Feb 6, 04:11
Owners added a reviewer: Restricted Owners Package.Wed, Feb 6, 04:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Feb 6, 04:11
Herald added a subscriber: schancel. · View Herald Transcript
florian retitled this revision from Fixed script error description to Fix script error description.Wed, Feb 6, 04:26
Mengerian requested changes to this revision.Wed, Feb 6, 05:03
Mengerian added a subscriber: Mengerian.

Good catch! I indicated a minor suggested rewording

src/script/script_error.cpp
75 ↗(On Diff #7194)

Seems to me it could be better as: "Only push operators allowed in scriptSig"

More accurate that way.

Also in the context of the other messages, which use "signature" to refer just the ECDSA signature.

This revision now requires changes to proceed.Wed, Feb 6, 05:03
florian updated this revision to Diff 7198.Wed, Feb 6, 14:24
florian marked an inline comment as done.

signtures->scriptSig

deadalnix added inline comments.Wed, Feb 6, 14:26
src/script/script_error.cpp
75 ↗(On Diff #7198)

signature scripts ? scriptSig is really a bad name.

florian updated this revision to Diff 7199.Wed, Feb 6, 14:41
florian marked an inline comment as done.

scriptSig -> signature scripts

Mengerian accepted this revision.Wed, Feb 6, 15:14

Sure, "signature scripts" works

This revision is now accepted and ready to land.Wed, Feb 6, 15:14
deadalnix accepted this revision.Wed, Feb 6, 15:19
This revision was automatically updated to reflect the committed changes.