Page MenuHomePhabricator
Differential D2505

Fix script error description
ClosedPublic
Actions

Authored by florian on Feb 6 2019, 04:11.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGb1eb229c4c3f: Fix script error description
rABCb1eb229c4c3f: Fix script error description
Summary

As per title

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

florian created this revision.Feb 6 2019, 04:11
Owners added a reviewer: Restricted Owners Package.Feb 6 2019, 04:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2019, 04:11
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 6 2019, 04:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

florian retitled this revision from Fixed script error description to Fix script error description.Feb 6 2019, 04:26
teamcity added a comment.Feb 6 2019, 04:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4884: Diff 7194.Feb 6 2019, 04:26
Mengerian requested changes to this revision.Feb 6 2019, 05:03
Mengerian added a subscriber: Mengerian.

Good catch! I indicated a minor suggested rewording

src/script/script_error.cpp
75 ↗(On Diff #7194)

Seems to me it could be better as: "Only push operators allowed in scriptSig"

More accurate that way.

Also in the context of the other messages, which use "signature" to refer just the ECDSA signature.

This revision now requires changes to proceed.Feb 6 2019, 05:03
florian updated this revision to Diff 7198.Feb 6 2019, 14:24
florian marked an inline comment as done.

signtures->scriptSig

teamcity added a comment.Feb 6 2019, 14:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added inline comments.Feb 6 2019, 14:26
src/script/script_error.cpp
75 ↗(On Diff #7198)

signature scripts ? scriptSig is really a bad name.

Harbormaster completed remote builds in B4888: Diff 7198.Feb 6 2019, 14:39
teamcity added a comment.Feb 6 2019, 14:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

florian updated this revision to Diff 7199.Feb 6 2019, 14:41
florian marked an inline comment as done.

scriptSig -> signature scripts

teamcity added a comment.Feb 6 2019, 14:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4889: Diff 7199.Feb 6 2019, 14:55
teamcity added a comment.Feb 6 2019, 14:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Mengerian accepted this revision.Feb 6 2019, 15:14

Sure, "signature scripts" works

This revision is now accepted and ready to land.Feb 6 2019, 15:14
deadalnix accepted this revision.Feb 6 2019, 15:19
Closed by commit rABCb1eb229c4c3f: Fix script error description (authored by florian). · Explain WhyFeb 6 2019, 15:27
This revision was automatically updated to reflect the committed changes.
florian added a commit: rSTAGINGb1eb229c4c3f: Fix script error description.Sep 18 2019, 22:17

Revision Contents
Changeset List

PathSize
src/
script/
2 lines

Diff 7201

View Options

src/script/script_error.cpp

Loading...