Page MenuHomePhabricator
Differential D2515

script_tests signature function renames to add "ECDSA"
ClosedPublic
Actions

Authored by markblundeberg on Feb 8 2019, 00:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG
Commits
rSTAGINGf8453ce6fe83: script_tests signature function renames to add "ECDSA"
rABCf8453ce6fe83: script_tests signature function renames to add "ECDSA"
Summary

Now that Schnorr sigs are there, would be nice to disambiguate both ways. Changes:
DoSign -> DoSignECDSA
PushSig -> PushSigECDSA
PushDataSig -> PushDataSigECDSA

(I left sign_multisig untouched even though it's ECDSA-only; there is no Schnorr counterpart.)

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4909
Build 7881: Bitcoin ABC Buildbot (legacy)
Build 7880: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 8 2019, 00:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2019, 00:32
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
markblundeberg added a task: T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG.Feb 8 2019, 00:32
teamcity added a subscriber: teamcity.Feb 8 2019, 00:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 8 2019, 00:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4909: Diff 7228.Feb 8 2019, 00:47
deadalnix accepted this revision.Feb 8 2019, 01:58
This revision is now accepted and ready to land.Feb 8 2019, 01:58
Closed by commit rABCf8453ce6fe83: script_tests signature function renames to add "ECDSA" (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyFeb 8 2019, 02:47
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGf8453ce6fe83: script_tests signature function renames to add "ECDSA".Sep 18 2019, 22:18

Revision Contents
Changeset List

PathSize
src/
test/
406 lines

Diff 7228

View Options

src/test/script_tests.cpp

Loading...