Page MenuHomePhabricator
Differential D2524

Revert "Revert "Merge #10712: Add change output if necessary to reduce excess fee""
AbandonedPublic
Actions

Authored by jasonbcox on Feb 8 2019, 19:44.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Summary

This reverts commit d22f9b07953801828ac4d906ca0cd5b924c93013.
Since D2522 fixes the issue from D2503, we can un-revert it.

Test Plan
test_runner.py
test_runner.py rpc_fundrawtransaction

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10712-rr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4923
Build 7909: Bitcoin ABC Buildbot (legacy)
Build 7908: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 8 2019, 19:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2019, 19:44
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 8 2019, 19:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 8 2019, 19:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4923: Diff 7249.Feb 8 2019, 19:59
deadalnix requested changes to this revision.Feb 8 2019, 22:38

Just redo the diff, instead of reverting a revert. Actual patch can be the same, but people don't need to play detective afterward.

This revision now requires changes to proceed.Feb 8 2019, 22:38
jasonbcox abandoned this revision.Feb 8 2019, 23:39

Revision Contents
Changeset List

PathSize
src/
wallet/
137 lines

Diff 7249

View Options

src/wallet/wallet.cpp

Loading...