Update contrib/seeds scripts to use the new .format() method
ClosedPublic
Actions

Authored by Fabien on Feb 19 2019, 14:17.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING9b7a70e1006d: Update contrib/seeds scripts to use the new .format() method
rABC9b7a70e1006d: Update contrib/seeds scripts to use the new .format() method

Summary

Avoid using % to format strings, switch to the new method instead.

Test Plan

Run a bitcoin seeder instance for at least 100s in order to get a
dnsseed.dump file. From a build directory:

./src/bitcoin-seeder

(wait 100s then kill it)

mv dnsseed.dump ../contrib/seeds/seeds_main.txt
cd ../contrib/seeds
./makeseeds.py < seeds_main.txt > nodes_main.txt
./generate-seeds.py . > chainparamsseeds.h
cat chainparamsseeds.h

Ensure the chainparamsseeds.h file is correctly formatted.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_python_format_seeds

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5024
Build 8111: Bitcoin ABC Buildbot (legacy)
Build 8110: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 19 2019, 14:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 19 2019, 14:17

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Feb 19 2019, 14:19

This revision is now accepted and ready to land.Feb 19 2019, 14:19

Harbormaster completed remote builds in B5024: Diff 7392.Feb 19 2019, 14:32

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC9b7a70e1006d: Update contrib/seeds scripts to use the new .format() method (authored by Fabien). · Explain WhyFeb 19 2019, 17:42

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING9b7a70e1006d: Update contrib/seeds scripts to use the new .format() method.Sep 18 2019, 22:27

Revision Contents
Changeset List

Path

Size

contrib/

seeds/

generate-seeds.py

makeseeds.py

4 lines

Diff 7392

View Options

contrib/seeds/generate-seeds.py