Page MenuHomePhabricator

Leave IBD in rpc_listtransactions
ClosedPublic

Authored by Fabien on Feb 28 2019, 14:07.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCa926b9f1f476: Leave IBD in rpc_listtransactions
Summary

The test won't run alone because IBD will prevent the inital
sync_all() to sync the mempools.

Test Plan
./test/functional/test_runner.py rpc_listtransactions

Will fail before the diff, but not after.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Feb 28 2019, 14:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2019, 14:07
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix accepted this revision.Feb 28 2019, 17:20

Please just backport the changes in the test and code associated instead of redoing everything next time.

This revision is now accepted and ready to land.Feb 28 2019, 17:20
Fabien added a comment.Feb 28 2019, 18:07

Oh I didn't noticed there was a backport for this, I did a quick search but missed it.
Thanks for pointing that, I will backport the other changes as well.

This revision was automatically updated to reflect the committed changes.