Fix FreeBSD build by including utilstrencodings.h
ClosedPublic
Actions

Authored by Fabien on Mar 5 2019, 09:30.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING3f0dc5337ceb: Fix FreeBSD build by including utilstrencodings.h
rABC3f0dc5337ceb: Fix FreeBSD build by including utilstrencodings.h

Summary

random.cpp needs to explicitly include utilstrencodings.h to get
ARRAYLEN. This fixes the FreeBSD build.

Backport of core PR13314

This patch has been proposed by Alex Dupre on the github mirror:
https://github.com/Bitcoin-ABC/bitcoin-abc/pull/304

Test Plan

Build and run bitcoind on FreeBSD

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13314

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5141
Build 8345: Bitcoin ABC Buildbot (legacy)
Build 8344: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 5 2019, 09:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 5 2019, 09:30

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5141: Diff 7592.Mar 5 2019, 09:44

deadalnix accepted this revision.Mar 5 2019, 15:45

This revision is now accepted and ready to land.Mar 5 2019, 15:45

Closed by commit rABC3f0dc5337ceb: Fix FreeBSD build by including utilstrencodings.h (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Fabien). · Explain WhyMar 5 2019, 18:19

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING3f0dc5337ceb: Fix FreeBSD build by including utilstrencodings.h.Sep 18 2019, 22:38

Revision Contents
Changeset List

Path

Size

src/

random.cpp

1 line

Diff 7592

View Options

Fix FreeBSD build by including utilstrencodings.hClosedPublicActions