Page MenuHomePhabricator
Differential D2655

[CMAKE] Split remove_compiler_flags into C and CXX variants
ClosedPublic
Actions

Authored by Fabien on Mar 6 2019, 12:14.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING531133ca14dd: [CMAKE] Split remove_compiler_flags into C and CXX variants
rABC531133ca14dd: [CMAKE] Split remove_compiler_flags into C and CXX variants
Summary

Keep a remove_compiler_flags macro that does both.

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja .. -DCMAKE_BUILD_TYPE=RelWithDebInfo
ninja -v

Check the -DNDEBUG does not appear on the compiler command lines.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_split_remove_compiler_flag
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5160
Build 8383: Bitcoin ABC Buildbot (legacy)
Build 8382: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 6 2019, 12:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 6 2019, 12:14
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 6 2019, 12:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D2644: [CMAKE] Override the flags for the Debug CMake configuration.Mar 6 2019, 12:26
Fabien mentioned this in D2644: [CMAKE] Override the flags for the Debug CMake configuration.
teamcity added a comment.Mar 6 2019, 12:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5160: Diff 7616.Mar 6 2019, 12:29
deadalnix accepted this revision.Mar 6 2019, 13:22
This revision is now accepted and ready to land.Mar 6 2019, 13:22
Closed by commit rABC531133ca14dd: [CMAKE] Split remove_compiler_flags into C and CXX variants (authored by Fabien). · Explain WhyMar 7 2019, 15:29
This revision was automatically updated to reflect the committed changes.
Fabien removed a child revision: D2644: [CMAKE] Override the flags for the Debug CMake configuration.Mar 8 2019, 12:35
Fabien added a commit: rSTAGING531133ca14dd: [CMAKE] Split remove_compiler_flags into C and CXX variants.Sep 18 2019, 22:38

Revision Contents
Changeset List

PathSize
cmake/
modules/
24 lines

Diff 7616

View Options

cmake/modules/AddCompilerFlags.cmake

Loading...