Page MenuHomePhabricator

Cleanup remaining instances of txconfirmtarget
ClosedPublic

Authored by jasonbcox on Mar 8 2019, 00:21.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rABC9a061e3de48f: Cleanup remaining instances of txconfirmtarget
Summary

Confirm target is no longer used, so cleaning it up. This operation is safe because now that txconfirmtarget will be simply ignored.

Test Plan
make check
bitcoin-qt # for sanity
bitcoin-qt --help # no longer contains help message for -txconftarget

Added txconfirmtarget=2 to bitcoin.conf
bitcoind operation was not disrupted.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Mar 8 2019, 00:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 8 2019, 00:21
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix accepted this revision.Mar 8 2019, 12:40
This revision is now accepted and ready to land.Mar 8 2019, 12:40
jasonbcox edited the test plan for this revision. (Show Details)Mar 8 2019, 17:18
This revision was automatically updated to reflect the committed changes.