Page MenuHomePhabricator

[CMAKE] Move .h files transformed from .ui to the form subdirectory
AbandonedPublic

Authored by Fabien on Thu, Mar 28, 15:14.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This is a prerequisite for PR11651, as all the qt headers will be
included with their path relative to src/.

Example: #include "ui_intro.h will become `#include
<qt/forms/ui_intro.h>`.

The ui_*.h files generated from the *.ui files are generated by
qt5_wrap_ui in the CMakeLists.txt file directory, wherever the
source *.ui files are located.

This diffs move the translation to a new CMakeLists.txt located in the
qt/forms subdirectory, so the ui_*.h files are generated here.

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_move_ui_files_forms
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5324
Build 8710: Bitcoin ABC Teamcity Staging
Build 8709: arc lint + arc unit

Event Timeline

Fabien created this revision.Thu, Mar 28, 15:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Mar 28, 15:14
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Wed, Apr 3, 19:59

You removed parallelism for no good reason.

This revision now requires changes to proceed.Wed, Apr 3, 19:59
deadalnix added inline comments.Wed, Apr 3, 19:59
src/qt/forms/CMakeLists.txt
6

That's not how it is done.

Fabien abandoned this revision.Tue, Apr 16, 08:09

Superseeded by D2786

src/qt/forms/CMakeLists.txt
6

This is required to define qt5_wrap_ui in this scope.
A similar thing is done for the locale generation which finds Qt5LinguistTools to get qt5_add_translation.