Page MenuHomePhabricator

GUI: Receive: Remove option to reuse a previous address
ClosedPublic

Authored by nakihito on Apr 15 2019, 22:19.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC646720f32fdc: GUI: Receive: Remove option to reuse a previous address
Summary

This was justified by the need to "resent" an invoice, but now that we have the request history, that need should be gone.

Backports PR3716
https://github.com/bitcoin/bitcoin/pull/3716/

Completes T599

Test Plan

make check
bitcoin-qt
Under the receive tab, there should be no option to reuse an existing receiving address.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Apr 15 2019, 22:19
Owners added a reviewer: Restricted Owners Package.Apr 15 2019, 22:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2019, 22:19
nakihito edited the summary of this revision. (Show Details)Apr 15 2019, 22:31
jasonbcox added inline comments.Apr 15 2019, 22:31
doc/release-notes.md
11 ↗(On Diff #8064)

s/removed./removed from the wallet.
just to clarify... (not all node operators are wallet users)

jasonbcox accepted this revision.Apr 15 2019, 22:33
This revision is now accepted and ready to land.Apr 15 2019, 22:33
nakihito updated this revision to Diff 8066.Apr 15 2019, 22:34
nakihito marked an inline comment as done.

Edited release notes to further clarify change in behavior.

nakihito updated this revision to Diff 8068.Apr 15 2019, 22:41

rebased.

This revision was landed with ongoing or failed builds.Apr 15 2019, 22:42
This revision was automatically updated to reflect the committed changes.