Paths

Table of Contentst

Differential D2806

Replace C compatibility headers by their C++ equivalent
ClosedPublic
Actions

Authored by Fabien on Apr 16 2019, 13:58.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING2258df118678: Replace C compatibility headers by their C++ equivalent
rABC2258df118678: Replace C compatibility headers by their C++ equivalent

Summary

For example, replace <stdint.h> with <cstdint>.

Test Plan

make check
ninja check

Cross build for windows

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Apr 16 2019, 13:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2019, 13:58

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5465: Diff 8072.Apr 16 2019, 14:13

deadalnix requested changes to this revision.Apr 16 2019, 15:34

deadalnix added inline comments.

src/crypto/ctaes/ctaes.h
11 ↗	(On Diff #8072)	That is actually a C library

This revision now requires changes to proceed.Apr 16 2019, 15:34

Don't update the C library

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5466: Diff 8073.Apr 16 2019, 15:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Apr 16 2019, 17:11

This revision is now accepted and ready to land.Apr 16 2019, 17:11

Closed by commit rABC2258df118678: Replace C compatibility headers by their C++ equivalent (authored by Fabien). · Explain WhyApr 16 2019, 17:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING2258df118678: Replace C compatibility headers by their C++ equivalent.Sep 18 2019, 22:58

Revision Contents
Changeset List

Path

Size

src/

crypto/

2 lines

2 lines

4 lines

2 lines

2 lines

2 lines

2 lines

2 lines

seeder/

main.cpp

2 lines

test/

univalue_tests.cpp

2 lines

Diff 8075

View Options

src/crypto/sha256_avx2.cpp

View Options

src/crypto/sha256_shani.cpp

View Options

src/crypto/sha256_sse4.cpp

View Options

src/crypto/sha256_sse41.cpp

View Options

src/fs.h

View Options

src/httpserver.cpp

View Options

src/init.cpp

View Options

src/net.cpp

View Options

src/seeder/main.cpp

View Options

src/test/univalue_tests.cpp

Replace C compatibility headers by their C++ equivalentClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8075

src/crypto/sha256_avx2.cpp

src/crypto/sha256_shani.cpp

src/crypto/sha256_sse4.cpp

src/crypto/sha256_sse41.cpp

src/fs.h

src/httpserver.cpp

src/init.cpp

src/net.cpp

src/seeder/main.cpp

src/test/univalue_tests.cpp

Replace C compatibility headers by their C++ equivalent
ClosedPublic
Actions

Revision Contents
Changeset List