Page MenuHomePhabricator
Differential D2806

Replace C compatibility headers by their C++ equivalent
ClosedPublic
Actions

Authored by Fabien on Apr 16 2019, 13:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING2258df118678: Replace C compatibility headers by their C++ equivalent
rABC2258df118678: Replace C compatibility headers by their C++ equivalent
Summary

For example, replace <stdint.h> with <cstdint>.

Test Plan
make check
ninja check

Cross build for windows

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_cheaders
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5466
Build 8994: Bitcoin ABC Buildbot (legacy)
Build 8993: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 16 2019, 13:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2019, 13:58
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Apr 16 2019, 13:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 16 2019, 14:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5465: Diff 8072.Apr 16 2019, 14:13
deadalnix requested changes to this revision.Apr 16 2019, 15:34
deadalnix added inline comments.
src/crypto/ctaes/ctaes.h
11 ↗(On Diff #8072)

That is actually a C library

This revision now requires changes to proceed.Apr 16 2019, 15:34
Fabien updated this revision to Diff 8073.Apr 16 2019, 15:41

Don't update the C library

teamcity added a comment.Apr 16 2019, 15:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5466: Diff 8073.Apr 16 2019, 15:56
teamcity added a comment.Apr 16 2019, 15:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Apr 16 2019, 17:11
This revision is now accepted and ready to land.Apr 16 2019, 17:11
Closed by commit rABC2258df118678: Replace C compatibility headers by their C++ equivalent (authored by Fabien). · Explain WhyApr 16 2019, 17:40
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING2258df118678: Replace C compatibility headers by their C++ equivalent.Sep 18 2019, 22:58

Revision Contents
Changeset List

PathSize
src/
crypto/
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
seeder/
2 lines
test/
2 lines

Diff 8073

View Options

src/crypto/sha256_avx2.cpp

Loading...
View Options

src/crypto/sha256_shani.cpp

Loading...
View Options

src/crypto/sha256_sse4.cpp

Loading...
View Options

src/crypto/sha256_sse41.cpp

Loading...
View Options

src/fs.h

Loading...
View Options

src/httpserver.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net.cpp

Loading...
View Options

src/seeder/main.cpp

Loading...
View Options

src/test/univalue_tests.cpp

Loading...