Page MenuHomePhabricator

Remove Safe mode
ClosedPublic

Authored by deadalnix on Apr 17 2019, 23:06.

Details

Reviewers
Fabien
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC5530e49c1819: Remove Safe mode
Summary
  • rpc: Move RPC_FORBIDDEN_BY_SAFE_MODE code to reserved section

Although this code is no longer ever sent back after removing safe mode,
it would be unwise to remove it from the header.

For one, it would be bad to accidentally re-use the number.

Also some API documentation / bindings are directly generated from the .h
file - this is why the "Aliases for backward compatibility" are there. We don't
want to break code that relies on this error code existing, even if it's never
generated.

So keep it around but move it to a reserved section.

  • Remove "rpc" category from GetWarnings

No longer used after removing safe mode.

This function can likely be simplified more, but I'll leave that
for later to make this easy to review.

This is a backport of Core PR13090

Test Plan
make check
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Apr 17 2019, 23:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 17 2019, 23:06
Fabien accepted this revision.Apr 18 2019, 07:25
This revision is now accepted and ready to land.Apr 18 2019, 07:25
jasonbcox accepted this revision.Apr 18 2019, 15:11
This revision was automatically updated to reflect the committed changes.