Page MenuHomePhabricator

Use angle bracket in include for src (part 1)
ClosedPublic

Authored by Fabien on Apr 22 2019, 11:45.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC7696d55089f2: Use angle bracket in include for src (part 1)
Summary

As per title

Partial backport of PR11651

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Apr 22 2019, 11:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2019, 11:45
jasonbcox requested changes to this revision.Apr 22 2019, 16:57
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/bitcoin-cli.cpp
20 ↗(On Diff #8199)

System lib should be in its own section after univalue.h

src/bitcoin-tx.cpp
26 ↗(On Diff #8199)

system lib after boost

This revision now requires changes to proceed.Apr 22 2019, 16:57
Fabien updated this revision to Diff 8209.Apr 22 2019, 17:16

Fix ordering

jasonbcox accepted this revision.Apr 22 2019, 17:37
This revision is now accepted and ready to land.Apr 22 2019, 17:37
Fabien updated this revision to Diff 8214.Apr 22 2019, 18:16

Add missing newlines

This revision was automatically updated to reflect the committed changes.