Use angle bracket in include for src (part 1)
ClosedPublic
Actions

Authored by Fabien on Apr 22 2019, 11:45.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING7696d55089f2: Use angle bracket in include for src (part 1)
rABC7696d55089f2: Use angle bracket in include for src (part 1)

Summary

As per title

Partial backport of PR11651

Test Plan

make check
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11651_part24

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5565
Build 9192: Bitcoin ABC Buildbot (legacy)
Build 9191: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 22 2019, 11:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2019, 11:45

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5551: Diff 8199.Apr 22 2019, 11:59

jasonbcox requested changes to this revision.Apr 22 2019, 16:57

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/bitcoin-cli.cpp
20 ↗	(On Diff #8199)	System lib should be in its own section after univalue.h
src/bitcoin-tx.cpp
26 ↗	(On Diff #8199)	system lib after boost

This revision now requires changes to proceed.Apr 22 2019, 16:57

Fix ordering

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5560: Diff 8209.Apr 22 2019, 17:29

jasonbcox accepted this revision.Apr 22 2019, 17:37

This revision is now accepted and ready to land.Apr 22 2019, 17:37

Add missing newlines

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5565: Diff 8214.Apr 22 2019, 18:30

Closed by commit rABC7696d55089f2: Use angle bracket in include for src (part 1) (authored by Fabien). · Explain WhyApr 22 2019, 19:21

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in T649: Backport PR11651.May 10 2019, 09:48

Fabien added a commit: rSTAGING7696d55089f2: Use angle bracket in include for src (part 1).Sep 18 2019, 23:05

Revision Contents
Changeset List

Path

Size

src/

4 lines

22 lines

12 lines

8 lines

2 lines

4 lines

8 lines

12 lines

16 lines

10 lines

11 lines

21 lines

39 lines

28 lines

2 lines

23 lines

2 lines

blockindexworkcomparator.h

2 lines

blockstatus.h

4 lines

bloom.cpp

16 lines

Diff 8214

View Options

src/addrdb.h

View Options

src/addrdb.cpp

View Options

src/addrman.h

View Options

src/addrman.cpp

View Options

src/amount.h

View Options

src/amount.cpp

View Options

src/arith_uint256.cpp

View Options

src/avalanche.h

View Options

src/avalanche.cpp

View Options

src/base58.h

View Options

src/base58.cpp

View Options

src/bitcoin-cli.cpp

View Options

src/bitcoin-tx.cpp

View Options

src/bitcoind.cpp

View Options

src/blockencodings.h

View Options

src/blockencodings.cpp

View Options

src/blockfileinfo.h

View Options

src/blockindexworkcomparator.h

View Options

src/blockstatus.h

View Options

Use angle bracket in include for src (part 1)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8214

src/addrdb.h

src/addrdb.cpp

src/addrman.h

src/addrman.cpp

src/amount.h

src/amount.cpp

src/arith_uint256.cpp

src/avalanche.h

src/avalanche.cpp

src/base58.h

src/base58.cpp

src/bitcoin-cli.cpp

src/bitcoin-tx.cpp

src/bitcoind.cpp

src/blockencodings.h

src/blockencodings.cpp

src/blockfileinfo.h

src/blockindexworkcomparator.h

src/blockstatus.h

src/bloom.cpp

Use angle bracket in include for src (part 1)
ClosedPublic
Actions

Revision Contents
Changeset List