Page MenuHomePhabricator

Use angle bracket in include for src (part 3)
ClosedPublic

Authored by Fabien on Apr 22 2019, 12:46.

Details

Summary

As per title

Partial backport of PR11651

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11651_part26
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5562
Build 9186: Bitcoin ABC Buildbot (legacy)
Build 9185: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Apr 22 2019, 17:01
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/dstencode.h
9 ↗(On Diff #8201)

separating line between system libs and internal dependencies

src/fs.cpp
1 ↗(On Diff #8201)

Nit: This file needs a copyright notice

src/init.cpp
53 ↗(On Diff #8201)

system libs section should be last

54 ↗(On Diff #8201)

this newline shouldn't exist so that csignal is with the other system libs

This revision now requires changes to proceed.Apr 22 2019, 17:01

Fix ordering + missing copyright

This revision is now accepted and ready to land.Apr 22 2019, 18:47
This revision was automatically updated to reflect the committed changes.