Page MenuHomePhabricator
Differential D2859

Use angle bracket in include for src (part 5)
ClosedPublic
Actions

Authored by Fabien on Apr 22 2019, 12:58.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING93704c28de90: Use angle bracket in include for src (part 5)
rABC93704c28de90: Use angle bracket in include for src (part 5)
Summary

As per title

Partial backport of PR11651

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11651_part28
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5563
Build 9188: Bitcoin ABC Buildbot (legacy)
Build 9187: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 22 2019, 12:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2019, 12:58
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Apr 22 2019, 12:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 22 2019, 13:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5555: Diff 8203.Apr 22 2019, 13:14
jasonbcox requested changes to this revision.Apr 22 2019, 17:05
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/scheduler.cpp
10 ↗(On Diff #8203)

newline after boost

src/serialize.h
24 ↗(On Diff #8203)

should be before system libs

src/torcontrol.cpp
16 ↗(On Diff #8203)

system libs at the end

This revision now requires changes to proceed.Apr 22 2019, 17:05
Fabien updated this revision to Diff 8212.Apr 22 2019, 18:04

Fix ordering

teamcity added a comment.Apr 22 2019, 18:05

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 22 2019, 18:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5563: Diff 8212.Apr 22 2019, 18:18
jasonbcox accepted this revision.Apr 22 2019, 18:48
This revision is now accepted and ready to land.Apr 22 2019, 18:48
Closed by commit rABC93704c28de90: Use angle bracket in include for src (part 5) (authored by Fabien). · Explain WhyApr 22 2019, 19:23
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in T649: Backport PR11651.May 10 2019, 09:48
Fabien added a commit: rSTAGING93704c28de90: Use angle bracket in include for src (part 5).Sep 18 2019, 23:06

Revision Contents
Changeset List

PathSize
src/
6 lines
24 lines
5 lines
32 lines
2 lines
7 lines
5 lines
4 lines
2 lines
6 lines
4 lines
16 lines
2 lines
21 lines
10 lines
20 lines

Diff 8212

View Options

src/random.h

Loading...
View Options

src/random.cpp

Loading...
View Options

src/rcu.cpp

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/scheduler.h

Loading...
View Options

src/scheduler.cpp

Loading...
View Options

src/serialize.h

Loading...
View Options

src/streams.h

Loading...
View Options

src/sync.h

Loading...
View Options

src/sync.cpp

Loading...
View Options

src/threadinterrupt.cpp

Loading...
View Options

src/timedata.cpp

Loading...
View Options

src/torcontrol.h

Loading...
View Options

src/torcontrol.cpp

Loading...
View Options

src/txdb.h

Loading...
View Options

src/txdb.cpp

Loading...