Page MenuHomePhabricator
Differential D2876

[qt] Simplifies boolean expression model && model->haveWatchOnly()
ClosedPublic
Actions

Authored by jasonbcox on Apr 24 2019, 20:48.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGaeb3ff3467ce: [qt] Simplifies boolean expression model && model->haveWatchOnly()
rABCaeb3ff3467ce: [qt] Simplifies boolean expression model && model->haveWatchOnly()
Summary

The boolean expression model && model->haveWatchOnly() can be simplified to model->haveWatchOnly(), because if (!model || !model->getOptionsModel()) { return; } guards against a potential dereferenced null pointer.

Backport of Core PR 12074
https://github.com/bitcoin/bitcoin/pull/12074/files
Depends on D2875

Test Plan

make check
bitcoin-qt # sanity checks on export txs

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12074
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5595
Build 9252: Bitcoin ABC Buildbot (legacy)
Build 9251: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 24 2019, 20:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 24 2019, 20:48
jasonbcox added a child revision: D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.Apr 24 2019, 20:49
teamcity added a comment.Apr 24 2019, 20:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 24 2019, 21:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5595: Diff 8261.Apr 24 2019, 21:03
jasonbcox mentioned this in D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.Apr 24 2019, 22:43
Fabien accepted this revision.Apr 25 2019, 06:30
This revision is now accepted and ready to land.Apr 25 2019, 06:30
Closed by commit rABCaeb3ff3467ce: [qt] Simplifies boolean expression model && model->haveWatchOnly() (authored by 251 <13120787+251Labs@users.noreply.github.com>, committed by jasonbcox). · Explain WhyApr 25 2019, 15:38
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGINGaeb3ff3467ce: [qt] Simplifies boolean expression model && model->haveWatchOnly().Sep 18 2019, 23:08

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines

Diff 8261

View Options

src/qt/transactionview.cpp

Loading...