Merge #11012: Make sure to clean up mapBlockSource if we've already seen the block
ClosedPublic
Actions

Authored by jasonbcox on Apr 30 2019, 00:07.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING297eb24c2b87: Merge #11012: Make sure to clean up mapBlockSource if we've already seen the…
rABC297eb24c2b87: Merge #11012: Make sure to clean up mapBlockSource if we've already seen the…

Summary

3f8fa7f Make sure to clean up mapBlockSource if we've already seen the block (Cory Fields)

Pull request description:

Otherwise we may leave them dangling.

Credit TheBlueMatt.

Tree-SHA512: 8be77e08ebfc4f5b206d5ee7cfbe87f92c1eb5bc2b412471993658fe210306789aaf0f3d1454c635508a7d8effede2cf5ac144d622b0157b872733d9661d65c3

Backport of Core PR 11012
https://github.com/bitcoin/bitcoin/pull/11012/files

Test Plan

make check
ninja check
bitcoind # sanity checking

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr11012

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5624
Build 9310: Bitcoin ABC Buildbot (legacy)
Build 9309: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 30 2019, 00:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 30 2019, 00:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5624: Diff 8303.Apr 30 2019, 00:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.Apr 30 2019, 12:18

This revision is now accepted and ready to land.Apr 30 2019, 12:18

Closed by commit rABC297eb24c2b87: Merge #11012: Make sure to clean up mapBlockSource if we've already seen the… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyApr 30 2019, 17:34

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING297eb24c2b87: Merge #11012: Make sure to clean up mapBlockSource if we've already seen the….Sep 18 2019, 23:10

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

9 lines

Diff 8303

View Options

Merge #11012: Make sure to clean up mapBlockSource if we've already seen the blockClosedPublicActions