Page MenuHomePhabricator
Differential D2892

[CMAKE] Add an option to enable the glibc compatibility features
ClosedPublic
Actions

Authored by Fabien on Apr 30 2019, 09:57.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGd0cbe069e7c6: [CMAKE] Add an option to enable the glibc compatibility features
rABCd0cbe069e7c6: [CMAKE] Add an option to enable the glibc compatibility features
Summary

The option ENABLE_GLIBC_BACK_COMPAT can be set to ON to configure
and include the functions from the compat/glibc_compat.cpp file. This
is a port of the configure option --enable-glibc-back-compat.

Test Plan

On a recent Linux with a glibc version > 2.17:

cmake -DENABLE_GLIBC_BACK_COMPAT=ON -GNinja ..
ninja
../contrib/devtools/symbol-check.py src/bitcoind | grep log2f

Before the patch, should return:

src/bitcoind: symbol log2f from unsupported version <glibc_version>

After the patch, should return nothing.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_glibc_compat
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5627
Build 9316: Bitcoin ABC Buildbot (legacy)
Build 9315: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 30 2019, 09:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 30 2019, 09:57
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Apr 30 2019, 09:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien updated this revision to Diff 8307.Apr 30 2019, 09:59

Rebase

teamcity added a comment.Apr 30 2019, 10:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 30 2019, 10:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5627: Diff 8306.Apr 30 2019, 10:12
teamcity added a comment.Apr 30 2019, 10:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5628: Diff 8307.Apr 30 2019, 10:13
deadalnix requested changes to this revision.May 5 2019, 16:48
deadalnix added inline comments.
src/CMakeLists.txt
162 ↗(On Diff #8307)

You should check for rt's presence. This is a miracle that it works at all, you probably have something in your build that requires rt transitively ?

This revision now requires changes to proceed.May 5 2019, 16:48
Fabien updated this revision to Diff 8408.May 6 2019, 08:03

Check for rt lib

teamcity added a comment.May 6 2019, 08:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5693: Diff 8408.May 6 2019, 08:18
teamcity added a comment.May 6 2019, 08:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien updated this revision to Diff 8591.May 10 2019, 10:09

Rebase

teamcity added a comment.May 10 2019, 10:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 10 2019, 10:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5798: Diff 8591.May 10 2019, 10:24
deadalnix accepted this revision.May 16 2019, 23:07
This revision is now accepted and ready to land.May 16 2019, 23:07
Closed by commit rABCd0cbe069e7c6: [CMAKE] Add an option to enable the glibc compatibility features (authored by Fabien). · Explain WhyMay 17 2019, 20:02
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGINGd0cbe069e7c6: [CMAKE] Add an option to enable the glibc compatibility features.Sep 18 2019, 23:36

Revision Contents
Changeset List

PathSize
src/
38 lines

Diff 8306

View Options

src/CMakeLists.txt

Loading...