Page MenuHomePhabricator

[CMAKE] Add an option to enable the glibc compatibility features
ClosedPublic

Authored by Fabien on Apr 30 2019, 09:57.

Details

Summary

The option ENABLE_GLIBC_BACK_COMPAT can be set to ON to configure
and include the functions from the compat/glibc_compat.cpp file. This
is a port of the configure option --enable-glibc-back-compat.

Test Plan

On a recent Linux with a glibc version > 2.17:

cmake -DENABLE_GLIBC_BACK_COMPAT=ON -GNinja ..
ninja
../contrib/devtools/symbol-check.py src/bitcoind | grep log2f

Before the patch, should return:

src/bitcoind: symbol log2f from unsupported version <glibc_version>

After the patch, should return nothing.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_glibc_compat
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5798
Build 9658: Bitcoin ABC Buildbot (legacy)
Build 9657: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 30 2019, 09:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 30 2019, 09:57
Fabien updated this revision to Diff 8307.Apr 30 2019, 09:59

Rebase

deadalnix requested changes to this revision.May 5 2019, 16:48
deadalnix added inline comments.
src/CMakeLists.txt
162 ↗(On Diff #8307)

You should check for rt's presence. This is a miracle that it works at all, you probably have something in your build that requires rt transitively ?

This revision now requires changes to proceed.May 5 2019, 16:48
Fabien updated this revision to Diff 8408.May 6 2019, 08:03

Check for rt lib

Fabien updated this revision to Diff 8591.May 10 2019, 10:09

Rebase

deadalnix accepted this revision.May 16 2019, 23:07
This revision is now accepted and ready to land.May 16 2019, 23:07
This revision was automatically updated to reflect the committed changes.