Merge #9517: [refactor] Switched httpserver.cpp to use RAII wrapped libevents.
ClosedPublic
Actions

Authored by jasonbcox on May 1 2019, 15:52.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGbe6f171382d9: Merge #9517: [refactor] Switched httpserver.cpp to use RAII wrapped libevents.
rABCbe6f171382d9: Merge #9517: [refactor] Switched httpserver.cpp to use RAII wrapped libevents.

Summary

1ae86ec Changed event RAII helper functions to inline to deal with duplicate symbol linker errors. (Karl-Johan Alm)
fd369d2 Switched httpserver.cpp to use RAII wrapped libevents. (Kalle Alm)

Tree-SHA512: 877e431f211024d42a3b0800e860e02833398611433e8393f8d5d4970f47f4bd670b900443678c067fec110c087aaab7dc1981ccbf17f6057676fdbbda89aed9

Backport of Core PR 9517
https://github.com/bitcoin/bitcoin/pull/9517/files

Test Plan

make check
ninja check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr9517

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5637
Build 9336: Bitcoin ABC Buildbot (legacy)
Build 9335: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 1 2019, 15:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2019, 15:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5637: Diff 8321.May 1 2019, 16:07

Fabien accepted this revision.May 1 2019, 18:13

This revision is now accepted and ready to land.May 1 2019, 18:13

Closed by commit rABCbe6f171382d9: Merge #9517: [refactor] Switched httpserver.cpp to use RAII wrapped libevents. (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 1 2019, 21:03

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGINGbe6f171382d9: Merge #9517: [refactor] Switched httpserver.cpp to use RAII wrapped libevents..Sep 18 2019, 23:11

Revision Contents
Changeset List

Path

Size

src/

httpserver.cpp

31 lines

support/

events.h

24 lines

Diff 8321

View Options

src/httpserver.cpp