Merge #11880: Stop special-casing phashBlock handling in validation for TBV
ClosedPublic
Actions

Authored by jasonbcox on May 1 2019, 22:52.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING408db0d765d9: Merge #11880: Stop special-casing phashBlock handling in validation for TBV
rABC408db0d765d9: Merge #11880: Stop special-casing phashBlock handling in validation for TBV

Summary

9c5a4a6ed Stop special-casing phashBlock handling in validation for TBV (Matt Corallo)

Pull request description:

There is no reason to do this, really, we already have "ignore PoW" flags. Motivated by https://github.com/bitcoin/bitcoin/pull/11739#discussion_r155841721

Tree-SHA512: 37cb1ae5b11c9e8ed7a679bb07ad3b119a2a014744b26d197d67ba21beb19fe6815271df935e40f7c7bd5f2e4d7ae4dad7bd4d00fa230a8d789f37e9de31a769

Backport of Core PR 11880
https://github.com/bitcoin/bitcoin/pull/11880/files

Test Plan

ninja check
make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.May 1 2019, 22:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 1 2019, 22:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5639: Diff 8330.May 1 2019, 23:07

Fabien accepted this revision.May 2 2019, 05:56

This revision is now accepted and ready to land.May 2 2019, 05:56

Closed by commit rABC408db0d765d9: Merge #11880: Stop special-casing phashBlock handling in validation for TBV (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 2 2019, 20:05

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING408db0d765d9: Merge #11880: Stop special-casing phashBlock handling in validation for TBV.Sep 18 2019, 23:12

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

12 lines

Diff 8346

View Options

Merge #11880: Stop special-casing phashBlock handling in validation for TBVClosedPublicActions