Page MenuHomePhabricator

Use angle bracket in include for qt tests
ClosedPublic

Authored by Fabien on May 3 2019, 10:01.

Details

Summary

As per title

Partial backport of PR11651

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11651_part12
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5665
Build 9392: Bitcoin ABC Buildbot (legacy)
Build 9391: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.May 3 2019, 17:02
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/test/compattests.cpp
8 ↗(On Diff #8359)

qt/

src/qt/test/guiutiltests.cpp
10 ↗(On Diff #8359)

qt/

src/qt/test/paymentservertests.cpp
16 ↗(On Diff #8359)

should be in first section

src/qt/test/rpcnestedtests.cpp
15 ↗(On Diff #8359)

move univalue into its own section and merge util and validation into the section above this.

src/qt/test/test_main.cpp
13 ↗(On Diff #8359)

merge sections

This revision now requires changes to proceed.May 3 2019, 17:02
src/qt/test/paymentservertests.cpp
16 ↗(On Diff #8359)

The test files are placed in a later section for consistency with other src/test pattern. The first one is an exception because it is the header associated with this source file.

src/qt/test/rpcnestedtests.cpp
15 ↗(On Diff #8359)

Good catch

src/qt/test/test_main.cpp
13 ↗(On Diff #8359)

Dito, the test files are placed deliberately in another section.

jasonbcox added inline comments.
src/qt/test/paymentservertests.cpp
16 ↗(On Diff #8359)

I think I misread this one. Carry on..

src/qt/test/test_main.cpp
13 ↗(On Diff #8359)

Got it.

This revision is now accepted and ready to land.May 3 2019, 21:13
This revision was automatically updated to reflect the committed changes.