Page MenuHomePhabricator

Merge #12415: Interrupt loading thread after shutdown request
ClosedPublic

Authored by jasonbcox on May 7 2019, 00:43.

Details

Summary

2e9406c Interrupt loading thread after shutdown request (João Barbosa)

Pull request description:

This change (currently) avoids loading the mempool if shutdown is requested.

Tree-SHA512: 3dca3a6ea5b09bd71db0974584d93dfe81819bc0bdbb4d9b6fa0474755306d1403f6c058ecb8211384493a8f7ca3a9134173db744b7344043cfc7d79286c8fd4

Backport of Core PR12415
https://github.com/bitcoin/bitcoin/pull/12415/files

Test Plan

make check
test_runner.py
bitcoind --testnet -help-debug -stopafterblockimport # shuts down as expected with this message in the logs: Stopping after block import

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr12415
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5785
Build 9632: Bitcoin ABC Teamcity Staging
Build 9631: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 7 2019, 00:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2019, 00:43
Fabien requested changes to this revision.May 7 2019, 06:24

Please update the test plan, make check does not cover the behavior change.

This revision now requires changes to proceed.May 7 2019, 06:24
jasonbcox edited the summary of this revision. (Show Details)May 9 2019, 00:15
jasonbcox edited the test plan for this revision. (Show Details)May 9 2019, 22:49
jasonbcox edited the test plan for this revision. (Show Details)May 9 2019, 22:58
Fabien accepted this revision.May 10 2019, 15:07
This revision is now accepted and ready to land.May 10 2019, 15:07
This revision was automatically updated to reflect the committed changes.