Merge #10057: [init] Deduplicated sigaction() boilerplate
ClosedPublic
Actions

Authored by jasonbcox on May 7 2019, 03:22.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING7735f949b68e: Merge #10057: [init] Deduplicated sigaction() boilerplate
rABC7735f949b68e: Merge #10057: [init] Deduplicated sigaction() boilerplate

Summary

81a3857 Deduplicated sigaction() boilerplate (Thomas Snider)

Tree-SHA512: 705b73f285a3d76504ba01476e072fdce67731b65f309bb04e4bbd765556c37e127cb769b475de2d68b33f50d7737fb136aefa0fa7c725a11ad16a47b9d0365f

Backport Core PR 10057
https://github.com/bitcoin/bitcoin/pull/10057/files

Test Plan

make check
bitcoind --testnet
ps aux | grep bitcoind
kill -s TERM <bitcoind-pid>
# bitcoind should be killed

bitcoind --testnet
rm ~/.bitcoin/testnet3/debug.log
ps aux | grep bitcoind
kill -s HUP <bitcoind-pid>
# debug.log should be recreated

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.May 7 2019, 03:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2019, 03:22

jasonbcox added inline comments.May 7 2019, 03:23

src/init.cpp
309 ↗	(On Diff #8448)	Note for reviewers: Bind() was removed in D1747

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5720: Diff 8448.May 7 2019, 03:37

Fabien accepted this revision.May 7 2019, 06:33

This revision is now accepted and ready to land.May 7 2019, 06:33

Closed by commit rABC7735f949b68e: Merge #10057: [init] Deduplicated sigaction() boilerplate (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyMay 7 2019, 15:18

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING7735f949b68e: Merge #10057: [init] Deduplicated sigaction() boilerplate.Sep 18 2019, 23:18

Revision Contents
Changeset List

Path

Size

src/

init.cpp

32 lines

Diff 8464

View Options

Merge #10057: [init] Deduplicated sigaction() boilerplateClosedPublicActions