Page MenuHomePhabricator

Merge #11831: Always return true if AppInitMain got to the end
ClosedPublic

Authored by jasonbcox on Tue, May 7, 03:40.

Details

Summary

07c4838 Always return true if AppInitMain got to the end (Matt Corallo)

Pull request description:

This should fix a rare zapwallettxes failure on travis, but also
avoids having init operations (re-adding wallet transactions to
mempool) running after RPC is free'd.

I believe this was the failure at https://travis-ci.org/bitcoin/bitcoin/jobs/311747844 (from #11605).

Tree-SHA512: f0fea8c1b9265e2eeda57043d541380a3e58e4d9388fa24628a52fd56324257fcd7df0ca02e8f77f66fadd68d951893bab0f610ed9fd0a89b2ccd6bad1efa351

Backport of Core PR 11831
https://github.com/bitcoin/bitcoin/pull/11831/files

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Tue, May 7, 03:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, May 7, 03:40
Fabien accepted this revision.Tue, May 7, 06:20

Note to other reviewers: the bugfix PR12377 has already been backported in D2545

This revision is now accepted and ready to land.Tue, May 7, 06:20
This revision was automatically updated to reflect the committed changes.