Page MenuHomePhabricator
Differential D2970

refactor: Include obj/build.h instead of build.h
ClosedPublic
Actions

Authored by Fabien on May 7 2019, 14:37.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING80e7e777e64c: refactor: Include obj/build.h instead of build.h
rABC80e7e777e64c: refactor: Include obj/build.h instead of build.h
Summary

Partial backport of core PR11651 (commit 96b9281)
https://github.com/bitcoin/bitcoin/pull/11651/commits/96b92810a6a9719e03fe7004d5d5c2d6f7b7a5ff

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11651_part34
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5730
Build 9522: Bitcoin ABC Buildbot (legacy)
Build 9521: arc lint + arc unit

Event Timeline

Fabien created this revision.May 7 2019, 14:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2019, 14:37
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 7 2019, 14:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B5730: Diff 8462!May 7 2019, 14:49
teamcity added a comment.May 7 2019, 14:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

jasonbcox requested changes to this revision.May 7 2019, 23:17
jasonbcox added a subscriber: jasonbcox.

Does not build. Clearing this off the queue for now...

This revision now requires changes to proceed.May 7 2019, 23:17
Fabien requested review of this revision.May 8 2019, 04:56

The build failure is due to flaky functional test not related to this diff.
@jasonbcox Could you please relaunch the build to have it green ? I don't have permission to do so.

teamcity added a comment.May 9 2019, 16:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 9 2019, 16:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5730: Diff 8462.May 9 2019, 16:50
jasonbcox accepted this revision.May 9 2019, 16:59
This revision is now accepted and ready to land.May 9 2019, 16:59
Closed by commit rABC80e7e777e64c: refactor: Include obj/build.h instead of build.h (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Fabien). · Explain WhyMay 9 2019, 19:00
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in T649: Backport PR11651.May 10 2019, 09:48
Fabien added a commit: rSTAGING80e7e777e64c: refactor: Include obj/build.h instead of build.h.Sep 18 2019, 23:27

Revision Contents
Changeset List

PathSize
src/
2 lines

Diff 8462

View Options

src/clientversion.cpp

Loading...