Page MenuHomePhabricator
Differential D3011

Merge #9833: Trivial: fix comments referencing AppInit2
ClosedPublic
Actions

Authored by markblundeberg on May 10 2019, 03:13.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING6c97506519c9: Merge #9833: Trivial: fix comments referencing AppInit2
rABC6c97506519c9: Merge #9833: Trivial: fix comments referencing AppInit2
Summary

backport PR9833 https://github.com/bitcoin/bitcoin/pull/9833/files
ef9f495 Trivial: fix comments referencing AppInit2 (Marko Bencun)

": Running AppInit2 in thread" was changed in D1928

Test Plan

read

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.May 10 2019, 03:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 10 2019, 03:13
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 10 2019, 03:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5791: Diff 8580.May 10 2019, 03:28
teamcity added a comment.May 10 2019, 03:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox requested changes to this revision.May 10 2019, 15:19
jasonbcox added inline comments.
src/qt/bitcoin.cpp
461 ↗(On Diff #8580)

duplicate?

This revision now requires changes to proceed.May 10 2019, 15:19
markblundeberg updated this revision to Diff 8601.May 10 2019, 16:17
markblundeberg marked an inline comment as done.

fix oopsie noticed by Jason

teamcity added a comment.May 10 2019, 16:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 10 2019, 16:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5807: Diff 8601.May 10 2019, 16:31
Fabien accepted this revision.May 13 2019, 11:18
jasonbcox accepted this revision.May 14 2019, 16:11
This revision is now accepted and ready to land.May 14 2019, 16:11
Closed by commit rABC6c97506519c9: Merge #9833: Trivial: fix comments referencing AppInit2 (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 14 2019, 17:16
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING6c97506519c9: Merge #9833: Trivial: fix comments referencing AppInit2.Sep 18 2019, 23:31

Revision Contents
Changeset List

PathSize
src/
12 lines
qt/
2 lines
script/
3 lines

Diff 8656

View Options

src/init.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/script/sigcache.cpp

Loading...