[CMAKE] Fix missing protobuf include directory
ClosedPublic
Actions

Authored by Fabien on May 13 2019, 08:06.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING116f9831e6c5: [CMAKE] Fix missing protobuf include directory
rABC116f9831e6c5: [CMAKE] Fix missing protobuf include directory

Summary

The Protobuf include directory has been mistakenly removed in D3016.

This patch reverts the previous wrong change.

Full explanation:
The include directories are automatically added by CMake when using
target_link_libraries on IMPORTED target, but this is not the case
here. IMPORTED targets have been added for protobuf in later CMake
versions, past our minimum required one.

Test Plan

mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja
./src/qt/bitcoin-qt # Sanity check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_fix_protobuf

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5821
Build 9704: Bitcoin ABC Buildbot (legacy)
Build 9703: arc lint + arc unit

Event Timeline

Fabien created this revision.May 13 2019, 08:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2019, 08:06

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5821: Diff 8620.May 13 2019, 08:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.May 15 2019, 18:43

This revision is now accepted and ready to land.May 15 2019, 18:43

Closed by commit rABC116f9831e6c5: [CMAKE] Fix missing protobuf include directory (authored by Fabien). · Explain WhyMay 16 2019, 07:26

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING116f9831e6c5: [CMAKE] Fix missing protobuf include directory.Sep 18 2019, 23:33

Revision Contents
Changeset List

Path

Size

src/

qt/

CMakeLists.txt

2 lines

Diff 8620

View Options

[CMAKE] Fix missing protobuf include directoryClosedPublicActions